Support AZURE_ENVIRONMENT_NAME for Azure Gov#688
Merged
CyberDem0n merged 3 commits intozalando:masterfrom Jan 27, 2022
Merged
Conversation
CyberDem0n
reviewed
Jan 14, 2022
| 'WALG_S3_SSE_KMS_ID', 'WALG_S3_SSE', 'WALG_DISABLE_S3_SSE', 'AWS_S3_FORCE_PATH_STYLE'] | ||
| azure_names = ['WALG_AZ_PREFIX', 'AZURE_STORAGE_ACCOUNT', 'AZURE_STORAGE_ACCESS_KEY', | ||
| 'AZURE_STORAGE_SAS_TOKEN', 'WALG_AZURE_BUFFER_SIZE', 'WALG_AZURE_MAX_BUFFERS'] | ||
| 'AZURE_STORAGE_SAS_TOKEN', 'WALG_AZURE_BUFFER_SIZE', 'WALG_AZURE_MAX_BUFFERS', 'AZURE_ENVIRONMENT_NAME'] |
Contributor
There was a problem hiding this comment.
https://github.com/zalando/spilo/pull/688/checks#step:7:6:
postgres-appliance/scripts/configure_spilo.py:760:121: E501 line too long (123 > 120 characters)
Please also update the documentation
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Contributor
|
Merged, thank you @kim0! |
christoph-heiss
pushed a commit
to cybertec-postgresql/spilo
that referenced
this pull request
Mar 29, 2022
Need to persist this env var `AZURE_ENVIRONMENT_NAME` for Azure gov to work. It helps the azure sdk select the correct endpoints.
zer0def
pushed a commit
to zer0def/spilo
that referenced
this pull request
May 28, 2022
Need to persist this env var `AZURE_ENVIRONMENT_NAME` for Azure gov to work. It helps the azure sdk select the correct endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to persist this env var
AZURE_ENVIRONMENT_NAMEfor Azure gov to work. It helps the azure sdk select the correct endpoints.