Skip to content

Conversation

@Carl-Zama
Copy link
Contributor

PR content/description

Add the GLWE keyswitch operation:

  • Add the ability to decompose slices (i.e. polynomials)
  • Add the ability to generate GLWE keyswitching keys
  • Add some polynomial operations needed for GLWE keyswitch
  • Add the GLWE keyswitch operation itself

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit [specification][conventional-breaking]

@Carl-Zama Carl-Zama requested a review from IceTDrinker November 4, 2024 16:10
@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@github-actions
Copy link

github-actions bot commented Nov 4, 2024

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't read much yet but I don't see a glwe_keyswitch test file in algorithms/test

could we have one with parameters that have low pfail ?

@IceTDrinker
Copy link
Member

@mayeul-zama I do believe this is available in TFHE-rs now right ?

@mayeul-zama
Copy link
Contributor

Yes, added in #2084 (which is based on this PR)

@mayeul-zama mayeul-zama closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants