Codex/backtesting adaptive sizing cleanup#7
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex/backtesting adaptive sizing cleanup
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…on default config_id
The /api/v3/strategy/daily-suggestion/{user_id} endpoint already declares config_id as optional and resolves the is_default=TRUE preset internally when omitted. The response echoes the resolved id back, and every downstream consumer in account-engine (telegram callback button, DB write) reads from the response field — not from this constant.
Hardcoding the preset id here forced lockstep updates whenever the analytics team changed the production default. Removing it makes analytics-engine the sole source of truth for "which preset is current."
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
taiiiiiiiiiiii
pushed a commit
that referenced
this pull request
May 24, 2026
Plan Tier 3 #7 (partial). Adds `pnpm lint:dead-env` wrapping scripts/check-dead-env.sh so the dead-env scan joins the `pnpm` script namespace and is discoverable alongside the other drift checkers. `check:local` now invokes the pnpm script instead of the raw bash path. Considered and rejected as not actually applicable: - "Absorb drift patterns into stronger presets" — the drift checkers catch outlier overrides (rootDir!=./src, non-standard types, jscpd local-key bleed), NOT common patterns. The presets already cover the common case; the lints are defensive backstops against weird overrides. Lifting outliers into presets is incoherent. - "Replace scripts-drift with turbo validation" — scripts-drift enforces herd consistency (>50% have script X → flag those without). Turbo has no equivalent; the existing checker is the only enforcement. - "Rewrite check-dead-env in TS" — purely cosmetic, no behavioral win. The 4 drift checkers (config-drift, scripts-drift, snapshot-sync, check-dead-env) stay as-is. They are working defensive infrastructure, not the "treatment failure" the plan framed them as. https://claude.ai/code/session_01VCU2uisRq7X58rrnWA2Ckd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.