Conversation
taejoonn
approved these changes
Oct 8, 2021
Contributor
taejoonn
left a comment
taejoonn
left a comment
There was a problem hiding this comment.
Builds and runs on Linux. Pending confirmation for Windows
added note if a user gets an error when running `release_build.sh`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a Mac running
./release_buildresults in an error because it can't locate ./pow/generate_opencl.go`.I re-added that file plus
gpuMiner.goand rango mod tidybecause of errors caused by missing file and imports.Please check to see that it'll still work on a PC with those files still included and also to check to see if building and setting up on a PC automatically deletes those files.
Note
If everything still works then we have to include those files in the staging and release branches when ready.