Added corsair scan

[javixeneize]

This PR adds Corsair as a ZAP plugin for active scan test

[lgtm-com]

This pull request introduces 1 alert when merging 68576b2 into c1cca64 - view on LGTM.com

new alerts:

• 1 for Syntax error

[javixeneize]

Changes added

[kingthorin]

@javixeneize Could you address @thc202’s review?

[javixeneize]

All the changes have been added but the evidence one. In other scripts i see they are doing similar to what i am doing which i believe is correct.

Showing the whole message will be more confusing

[javixeneize]

Done now

[javixeneize]

that was another field, not evidence. Added now

[kingthorin]

This needs a CHANGELOG entry, if we are otherwise happy with the script I’m happy to tackle it. (And flatten things)

[javixeneize]

Yes, I’m happy with it. Thanks El El mié, 20 oct 2021 a las 1:27, Rick M ***@***.***> escribió:

…

This needs a CHANGELOG entry, if we are otherwise happy with the script I’m happy to tackle it. (And flatten things) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#208 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBLTZT3U5N3ULAK7ZGTKMLUHYEG7ANCNFSM4YOURAYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[kingthorin]

@javixeneize can you please make sure that "Allow edits from maintainers" is set?
https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

[javixeneize]

Hi

Apparently this can only be done in user-owned repos, i cant see that option in the forked repo (it was forked in an org)

[kingthorin]

Could you pull from: https://github.com/kingthorin/community-scripts/tree/master-ssr

Those are the outstanding changes.

[javixeneize]

I’m not following, you mean do a pr from that reto to the zap one? El El mié, 20 oct 2021 a las 17:26, Rick M ***@***.***> escribió:

…

Could you pull from: https://github.com/kingthorin/community-scripts/tree/master-ssr Those are the outstanding changes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#208 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBLTZQKCLUVEDATYESPDATUH3UT5ANCNFSM4YOURAYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[kingthorin]

No I mean add that as a remote, fetch it, hard reset to its state. Then force push to this branch (on your origin).

[javixeneize]

Changes done

[thc202]

Did you hard reset to that commit? Seems some changes were reverted instead.

[javixeneize]

i did reset to head, yes

git reset --hard HEAD

[thc202]

Could you do git reset --hard c2067b9dd5300903b17c602f990fff38c3b606d7 instead?

[javixeneize]

It cant resolve that commit

git reset --hard c2067b9
fatal: Could not parse object 'c2067b9dd5300903b17c602f990fff38c3b606d7'.

[thc202]

Do git fetch https://github.com/kingthorin/community-scripts.git master-ssr first.

[javixeneize]

done now

[thc202]

Thank you!