Skip to content

Conversation

@Prince-Mendiratta
Copy link
Contributor

Details
DMARC and SPF are a set of email authentication protocols configured domain wide which verify that incoming mail from a specific domain comes from an IP Address authorized by that domain’s administrators and help prevent email spoofing. These protocols are configured over DNS as TXT records.

Our team at Astra Security would like to contribute the scan rule to check if these protocols are configured on a domain or not.

Screenshots
Layer 1

Layer 2

Signed-off-by: Prince Mendiratta prince.mendiratta@getastra.com

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2021

This pull request introduces 2 alerts when merging 6de0294 into 8d82882 - view on LGTM.com

new alerts:

  • 2 for Missing space in string concatenation

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the inconsistent indent this weeks good to me.

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor thing. Just for tiddy code. Could you either remove or consistently use semi-colons?

@Prince-Mendiratta
Copy link
Contributor Author

One more minor thing. Just for tiddy code. Could you either remove or consistently use semi-colons?

Sure thing, bad habit :P

@kingthorin
Copy link
Member

Sure thing, bad habit :P

No worries, as you can tell I didn't notice it till the last second either.

@thc202
Copy link
Member

thc202 commented Sep 7, 2021

Could you address the conflict? (Better move before one of the existing entries to avoid conflict with the other ready PR.)

Signed-off-by: Prince Mendiratta <prince.mendiratta@getastra.com>
@kingthorin

This comment has been minimized.

@Prince-Mendiratta
Copy link
Contributor Author

Thank you, trying this out for the first time so a bit messy. The conflict should've been resolved now I believe.

@thc202 thc202 merged commit e1e19f5 into zaproxy:main Sep 7, 2021
@thc202
Copy link
Member

thc202 commented Sep 7, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants