-
-
Notifications
You must be signed in to change notification settings - Fork 255
Targeted script to check for DMARC / SPF policies #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request introduces 2 alerts when merging 6de0294 into 8d82882 - view on LGTM.com new alerts:
|
6de0294 to
03a516f
Compare
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the inconsistent indent this weeks good to me.
03a516f to
b6f0d62
Compare
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b6f0d62 to
8f6774b
Compare
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor thing. Just for tiddy code. Could you either remove or consistently use semi-colons?
Sure thing, bad habit :P |
8f6774b to
fd02a8f
Compare
No worries, as you can tell I didn't notice it till the last second either. |
|
Could you address the conflict? (Better move before one of the existing entries to avoid conflict with the other ready PR.) |
fd02a8f to
481660a
Compare
Signed-off-by: Prince Mendiratta <prince.mendiratta@getastra.com>
This comment has been minimized.
This comment has been minimized.
|
Thank you, trying this out for the first time so a bit messy. The conflict should've been resolved now I believe. |
|
Thank you! |
Details
DMARC and SPF are a set of email authentication protocols configured domain wide which verify that incoming mail from a specific domain comes from an IP Address authorized by that domain’s administrators and help prevent email spoofing. These protocols are configured over DNS as TXT records.
Our team at Astra Security would like to contribute the scan rule to check if these protocols are configured on a domain or not.
Screenshots

Signed-off-by: Prince Mendiratta prince.mendiratta@getastra.com