Update js scripts to use passed variables #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ricekot <github@ricekot.com>
ricekot
force-pushed
the
use-passed-variables
branch
from
43a00df to
e35c51b
Compare
kingthorin
approved these changes
May 31, 2022
thc202
approved these changes
Jun 3, 2022
Member
|
Thank you! |
Member
|
As discussed earlier do other script languages need similar handling and could/should we be handilng at the add-on or engine vs in each script? |
Member
|
This handling is temporary, once 2.12 is out the checks will no longer be needed. |
Member
|
Perfect, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.