Prevent and warn on curl file inclusion #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
approved these changes
Mar 28, 2023
kingthorin
reviewed
Mar 28, 2023
kingthorin
approved these changes
Mar 28, 2023
|
Thanks @thc202, sorry I shoulda read through things before commenting in my previous review 😉 |
Use `--data-raw` instead of `data-binary` which does not allow local file inclusion in the body. Warn when file inclusion is being done in a custom header and do not add the generated command to the clipboard (there does not seem to be an alternative argument that does not use the `@file` syntax). Thanks to James Kettle (@albinowax) for reporting. Signed-off-by: thc202 <thc202@gmail.com>
|
Pushed to trigger CI and to check the header trimmed (since it's being added that way). |
kingthorin
approved these changes
Mar 28, 2023
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
Mar 28, 2023
Apply changes done in zaproxy/community-scripts#319. Signed-off-by: thc202 <thc202@gmail.com>
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
Mar 28, 2023
Apply changes done in zaproxy/community-scripts#319. Signed-off-by: thc202 <thc202@gmail.com>
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
Mar 28, 2023
Apply changes done in zaproxy/community-scripts#319 and sync the script. Signed-off-by: thc202 <thc202@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
--data-rawinstead ofdata-binarywhich does not allow local file inclusion in the body.Warn when file inclusion is being done in a custom header and do not add the generated command to the clipboard (there does not seem to be an alternative argument that does not use the
@filesyntax).Thanks to James Kettle (@albinowax) for reporting.