Sync changes from zaproxy#515
Conversation
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
|
Isn't this syncing? It would be easier to follow the history if it stated (PR/commit) this is just a sync from the main repo. |
|
Sure |
kingthorin
changed the title
kingthorin
force-pushed
the
docker-sync
branch
2 times, most recently
from
220554c to
e41b625
Compare
|
They don't seem to be properly synced, which zaproxy commit was used for the sync? |
There was a problem hiding this comment.
Pull request overview
Synchronizes the HTTP Sender “Alert on HTTP Response Code Errors” script with upstream ZAP changes (per zaproxy/zaproxy#9275 and zaproxy/zaproxy#9273), aiming to better identify distinct alert variants.
Changes:
- Add
alertRefdifferentiation for 4xx vs 5xx alerts and setAlert#setAlertRef(...)accordingly. - Update
CHANGELOG.mdwith an entry noting the upstream sync.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| httpsender/Alert on HTTP Response Code Errors.js | Adds alertRef variant and sets alert.setAlertRef(...) for clearer alert identification. |
| CHANGELOG.md | Documents the upstream sync in the Unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -95,6 +97,7 @@ function responseReceived(msg, initiator, helper) { | |||
| "Raised by the 'Alert on HTTP Response Code Error' script" | |||
|
I didn't do a file copy the formatting and semicolons are different. I just inserted the three lines. In the zaproxy PR which introduced these changes one line was setting ref before title the other was after title, I made that consistent. |
|
I'd suggest copy them (spotless would remove any formatting differences), there are differences that should be applied regardless (don't mind the title swap). Also, please include the commit hash in the commit message for future reference/tracking. |
kingthorin
force-pushed
the
docker-sync
branch
2 times, most recently
from
586d0f4 to
37b600b
Compare
- AlertOnHttpResponseCodeErrors.js : Based on zaproxy f6f3ebe6de5e34d043732e92be5c6410b29b6a36 - AlertOnUnexpectedContentTypes.js : Based on zaproxy ffe308dce7d613ffc30ebbb736de4873d143b3b4 Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
|
Thank you! |
Per: zaproxy/zaproxy#9275 and zaproxy/zaproxy#9273