Skip to content

Conversation

profclems
Copy link
Contributor

@profclems profclems commented Mar 3, 2021

Make installer script POSIX compliant by removing bashisms and make it compatible with sh

Resolves #339

make installer script POSIX compliant by removing bashisms and make it compatible with sh
@profclems profclems changed the title patch 1 make installer script POSIX compliant Mar 3, 2021
@profclems profclems changed the title make installer script POSIX compliant Make installer script POSIX compliant Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #612 (6208470) into master (644586b) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   57.55%   57.60%   +0.05%     
==========================================
  Files          72       72              
  Lines        4446     4449       +3     
==========================================
+ Hits         2559     2563       +4     
  Misses       1644     1644              
+ Partials      243      242       -1     
Impacted Files Coverage Δ
cmd/fork.go 53.84% <0.00%> (ø)
cmd/mr_create.go 75.38% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb03a0...6208470. Read the comment docs.

Copy link
Collaborator

@prarit prarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the changes.

@bmeneg bmeneg merged commit 50add0a into zaquestion:master Mar 4, 2021
@profclems profclems deleted the patch-1 branch March 11, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install script is not Posix

3 participants