Skip to content

ZEP-0035 Feature Flags revision 3#42

Merged
mkcp merged 2 commits intomainfrom
mkcp/0035-rev3
Aug 25, 2025
Merged

ZEP-0035 Feature Flags revision 3#42
mkcp merged 2 commits intomainfrom
mkcp/0035-rev3

Conversation

@mkcp
Copy link
Copy Markdown
Contributor

@mkcp mkcp commented Aug 13, 2025

  • One-line PR description:
    Updates ZEP-0035 to alpha.

  • Issue link: Feature Flags #35

  • Other comments:
    Mostly updates to the configuration section and fixing the TODOs that are now knowns.

Signed-off-by: Kit Patella <kit@defenseunicorns.com>
@mkcp mkcp self-assigned this Aug 13, 2025
@mkcp mkcp requested review from a team August 13, 2025 20:39
AustinAbro321
AustinAbro321 previously approved these changes Aug 14, 2025
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typos / docs

Comment thread 0035-feature-flags/README.md Outdated
- Parse flags in defaults table, generate markdown table from the list.
- K8s website has a good example here (link)
### CLI: Enabling and Disabling Features
There are two approaches main approaches here, made available by Zarf's use of Viper: `CLI Flags`, `Env Vars`, and
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two approaches main approaches here, made available by Zarf's use of Viper: CLI Flags, Env Vars, and
zarf-config.{yaml,toml}.

"approaches" used twice and three items in total.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest

Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkcp mkcp merged commit b560850 into main Aug 25, 2025
1 check passed
@mkcp mkcp deleted the mkcp/0035-rev3 branch August 25, 2025 19:55
@mkcp mkcp mentioned this pull request Sep 29, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants