feat(src/internal/package2/pull.go): Check if package exists for OCI layers#3252
Closed
jamestexas wants to merge 2 commits intozarf-dev:mainfrom
jamestexas:issues/2780
Closed
feat(src/internal/package2/pull.go): Check if package exists for OCI layers#3252jamestexas wants to merge 2 commits intozarf-dev:mainfrom jamestexas:issues/2780
jamestexas wants to merge 2 commits intozarf-dev:mainfrom
jamestexas:issues/2780
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Contributor
|
Hey @jamestexas ! Is this something you'd still like to work on? It's still an impactful issue, let us know if you have any questions. 🙏 |
Contributor
Author
|
Heya @mkcp this was waiting on an internal update to Zarf before it could get iterated on. I since was part of the RiF so don't have it on my priority list at this time, sorry for the trouble! |
Member
|
Closing this as in #3767 we are instead caching each of the layers which will make subsequent pulls extremely fast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR's goal is to check if we have already have an OCI image locally before we pull it again. This should help ensure we don't re-pull each time. Tests will be done after the upcoming updates to publish are done.
This is the output comparing the execution time from a repeat run (removed other bits of the logging just to denote the pieces that mattered):
Output from the script:
First Run:
Repeat Run:
Related Issue
Fixes #2780
Relates to #
Checklist before merging