Readability improvements to README#14
Merged
emmanuelmathot merged 9 commits intoMay 20, 2026
Merged
Conversation
kylebarron
commented
Apr 7, 2026
Contributor
emmanuelmathot
left a comment
There was a problem hiding this comment.
A few inline suggestions, plus two heads-ups:
- Stale
proj:convention-name references remain outside the diff hunks: line 105 (bboxdescription), line 348 example heading (### Composition with proj: Convention) and intro, line 452 (Note how CRS information (proj:) is separated...), and FAQ entries at lines 491, 499, 501, 503, 507, 510 -- many of these useproj:to mean the convention, not the key prefix. Worth a follow-up pass to be consistent with this PR's stated rule. - Likely conflicts with two open PRs touching the same sections: #11 rewrites the
spatial:transformcoordinate-convention / registration prose, and #24 restricts the schema and field descriptions to 2D and removes the 3D bullets inspatial:dimensions/spatial:bbox/spatial:shape. Probably easiest to land #11 and #24 first, then rebase this.
Collaborator
|
@emmanuelmathot @kylebarron would either of you have time to resolve Emmanuel's comments and sync this with the latest changes on main? |
Co-authored-by: Emmanuel Mathot <emmanuel.mathot@gmail.com>
…o kyle/readme-edits
Co-authored-by: Emmanuel Mathot <emmanuel.mathot@gmail.com>
Co-authored-by: Emmanuel Mathot <emmanuel.mathot@gmail.com>
Contributor
Author
|
I think I've resolved all concerns and this should be good to merge |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
geo-proj, notproj:.proj:is the key prefix andgeo-projseems to be the proper name of the conventiongeo-projandmultiscalesconventions when we reference them.spatial:transformwith multiscales" as part of the definition ofspatial:transform, not the example section.