Skip to content

Update cpuinfo to 9.0.0#370

Merged
jakirkham merged 1 commit intozarr-developers:mainfrom
DimitriPapadopoulos:cpuinfo
Oct 28, 2022
Merged

Update cpuinfo to 9.0.0#370
jakirkham merged 1 commit intozarr-developers:mainfrom
DimitriPapadopoulos:cpuinfo

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 27, 2022

Released on 2022-10-25

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py310 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Oct 27, 2022

This pull request fixes 23 alerts when merging 69d2d60 into a3e05fd - view on LGTM.com

fixed alerts:

  • 10 for Testing equality to None
  • 6 for Except block handles 'BaseException'
  • 4 for Variable defined multiple times
  • 2 for Unnecessary pass
  • 1 for Unused local variable

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review October 27, 2022 11:01
@jakirkham
Copy link
Copy Markdown
Member

Thanks Dimitri! 🙏

This looks great. Would just suggest adding a changelog entry

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Oct 28, 2022

This pull request fixes 23 alerts when merging 80c4a2d into a3e05fd - view on LGTM.com

fixed alerts:

  • 10 for Testing equality to None
  • 6 for Except block handles 'BaseException'
  • 4 for Variable defined multiple times
  • 2 for Unnecessary pass
  • 1 for Unused local variable

@jakirkham jakirkham merged commit 176ad43 into zarr-developers:main Oct 28, 2022
@DimitriPapadopoulos DimitriPapadopoulos deleted the cpuinfo branch October 28, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants