Conversation
|
This pull request fixes 5 alerts when merging 67dec4d into d12b54b - view on LGTM.com fixed alerts:
|
67dec4d to
19ea966
Compare
jakirkham
left a comment
There was a problem hiding this comment.
On PyPI this is called py-cpuinfo, so suggesting updating requirements below accordingly
|
Thanks Dimitri! 🙏 |
|
This pull request fixes 5 alerts when merging 19ea966 into d12b54b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 5 alerts when merging 8dc047f into d12b54b - view on LGTM.com fixed alerts:
|
8dc047f to
7059ebc
Compare
|
This pull request fixes 5 alerts when merging 7059ebc into 0a2ec9f - view on LGTM.com fixed alerts:
|
7059ebc to
8705ee3
Compare
|
This pull request fixes 5 alerts when merging 8705ee3 into 0a2ec9f - view on LGTM.com fixed alerts:
|
8705ee3 to
c649c9b
Compare
|
This pull request fixes 5 alerts when merging c649c9b into 0a2ec9f - view on LGTM.com fixed alerts:
|
Bacause the cpuinfo module is required by setup.py, we need to install it with pyproject.toml.
c649c9b to
6164e68
Compare
|
This pull request fixes 5 alerts when merging 6164e68 into 0a2ec9f - view on LGTM.com fixed alerts:
|
jakirkham
left a comment
There was a problem hiding this comment.
Looks good. Thanks Dimitri! 🙏
|
This pull request fixes 5 alerts when merging 1e1d58e into 61a90da - view on LGTM.com fixed alerts:
|
|
Thanking of the upcoming release, best to bump to |
|
Agreed. Opened issue ( #377 ) so we can sort out anything for the next release. Hoping to have a couple more build fixes done, but will see. Depends on time constraints & help from others (like with |
Because the
cpuinfomodule is required bysetup.py, we need to pull it withpyproject.toml.I think it is not needed inrequirements_dev.txt.TODO:
tox -e py310passes locallytox -e docspasses locally