Skip to content

Add extra test case for bitround error#393

Merged
jakirkham merged 1 commit intozarr-developers:mainfrom
martindurant:cov_bitround
Nov 7, 2022
Merged

Add extra test case for bitround error#393
jakirkham merged 1 commit intozarr-developers:mainfrom
martindurant:cov_bitround

Conversation

@martindurant
Copy link
Copy Markdown
Member

@martindurant martindurant commented Nov 7, 2022

#392 (comment)

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@martindurant martindurant mentioned this pull request Nov 7, 2022
7 tasks
@martindurant
Copy link
Copy Markdown
Member Author

When I pulled from main to make this change:

45 files changed, 370 insertions(+), 83033 deletions(-)

:)

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 7, 2022

Codecov Report

Merging #393 (9c64a1f) into main (ff65b71) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   99.57%   99.61%   +0.04%     
==========================================
  Files          54       54              
  Lines        2099     2101       +2     
==========================================
+ Hits         2090     2093       +3     
+ Misses          9        8       -1     
Impacted Files Coverage Δ
numcodecs/tests/test_bitround.py 100.00% <100.00%> (ø)
numcodecs/bitround.py 100.00% <0.00%> (+3.03%) ⬆️

@jakirkham
Copy link
Copy Markdown
Member

Thanks Martin! 🙏

@jakirkham jakirkham merged commit 91d05e4 into zarr-developers:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants