Skip to content

Conversation

@jakirkham
Copy link
Member

Bring coverage back up to 100%.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Since nothing is done in this case, we can just skip having it. So drop
this case.
@jakirkham jakirkham changed the title Fix coverage Bring coverage back up to 100% Nov 7, 2022
@jakirkham jakirkham requested a review from joshmoore November 7, 2022 12:31
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Coverage definitely improved. 👍 (Let me know if you want help identifying the last few percentage points)

@jakirkham jakirkham enabled auto-merge (squash) November 7, 2022 19:35
@jakirkham jakirkham disabled auto-merge November 7, 2022 19:39
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #392 (9130735) into main (91d05e4) will increase coverage by 0.38%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #392      +/-   ##
===========================================
+ Coverage   99.61%   100.00%   +0.38%     
===========================================
  Files          54        53       -1     
  Lines        2101      2024      -77     
===========================================
- Hits         2093      2024      -69     
+ Misses          8         0       -8     
Impacted Files Coverage Δ
numcodecs/ndarray_like.py 100.00% <ø> (+12.50%) ⬆️
numcodecs/tests/test_registry.py 100.00% <ø> (+4.34%) ⬆️
numcodecs/zfpy.py 100.00% <ø> (+2.43%) ⬆️
numcodecs/__init__.py

@jakirkham
Copy link
Member Author

Thanks all! 🙏 Merging to get this fixed. We can follow up on anything else afterwards.

@jakirkham jakirkham merged commit 65decf1 into zarr-developers:main Nov 7, 2022
@jakirkham jakirkham deleted the fix_cov branch November 7, 2022 20:53
@joshmoore
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants