-
Notifications
You must be signed in to change notification settings - Fork 107
fix/revert 792 #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/revert 792 #802
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (61.76%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
+ Coverage 89.08% 98.68% +9.60%
==========================================
Files 64 64
Lines 2574 2595 +21
==========================================
+ Hits 2293 2561 +268
+ Misses 281 34 -247
🚀 New features to boost your workflow:
|
|
Thanks both for sorting out this solution. |
|
thank you @maxrjones and @jhamman! |
This PR partially reverts the changes in #792 by allowing either the old crc32c package or the google crc32c package to be used for the crc32c checksum. This will fix issues in zarr-python related to a missing crc32c import.