Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 20, 2025

This PR partially reverts the changes in #792 by allowing either the old crc32c package or the google crc32c package to be used for the crc32c checksum. This will fix issues in zarr-python related to a missing crc32c import.

@d-v-b d-v-b mentioned this pull request Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.68%. Comparing base (91dfe42) to head (1d922db).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
numcodecs/tests/test_checksum32.py 53.33% 7 Missing ⚠️
numcodecs/checksum32.py 68.42% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (61.76%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (98.68%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   89.08%   98.68%   +9.60%     
==========================================
  Files          64       64              
  Lines        2574     2595      +21     
==========================================
+ Hits         2293     2561     +268     
+ Misses        281       34     -247     
Files with missing lines Coverage Δ
numcodecs/checksum32.py 94.54% <68.42%> (+2.54%) ⬆️
numcodecs/tests/test_checksum32.py 93.33% <53.33%> (+9.29%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones merged commit 82fe1e5 into zarr-developers:main Nov 21, 2025
38 of 40 checks passed
@jhamman
Copy link
Member

jhamman commented Nov 21, 2025

Thanks both for sorting out this solution.

@d-v-b
Copy link
Contributor Author

d-v-b commented Nov 21, 2025

thank you @maxrjones and @jhamman!

@d-v-b d-v-b deleted the fix/revert-792 branch November 21, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants