fix(storage): MemoryStore.list_prefix uses directory-boundary semantics#3842
Open
NIK-TIGER-BILL wants to merge 2 commits intozarr-developers:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3773
MemoryStore.list_prefix("0")was returning keys from sibling paths (e.g."0_c/zarr.json") because it used a rawstr.startswithcheck.LocalStorecorrectly uses filesystem directory semantics and only returns items under the"0/"directory.This PR makes
MemoryStore.list_prefixconsistent withLocalStoreby normalising the prefix to always end with/before matching.Root Cause
Repro
Changes
src/zarr/storage/_memory.py:list_prefixnow normalises the prefix to end with/tests/test_store/test_memory.py: regression testtest_list_prefix_path_boundaryCloses #3773