Skip to content

Fix V3 time types#3955

Merged
d-v-b merged 1 commit intozarr-developers:mainfrom
chuckwondo:fix-time-typing
May 7, 2026
Merged

Fix V3 time types#3955
d-v-b merged 1 commit intozarr-developers:mainfrom
chuckwondo:fix-time-typing

Conversation

@chuckwondo
Copy link
Copy Markdown
Contributor

@chuckwondo chuckwondo commented May 7, 2026

The zarr.core.dtype.npy.time.DateTime64JSON_V3 and TimeDelte64JSON_V3 types erroneously subclassed zarr.core.common.NamedConfig rather than NamedRequiredConfig. This fixes that and also fixes the broken links in their docstrings to point to the correct source documentation for extension types.

  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 7, 2026
@d-v-b d-v-b enabled auto-merge (squash) May 7, 2026 22:47
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (6e7f2f3) to head (9575a54).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3955   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          87       87           
  Lines       11721    11721           
=======================================
  Hits        10932    10932           
  Misses        789      789           
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/time.py 98.85% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b merged commit 1445001 into zarr-developers:main May 7, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants