chore: remove warning on fixed length utf32#3979
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
==========================================
- Coverage 93.32% 93.32% -0.01%
==========================================
Files 88 88
Lines 11828 11827 -1
==========================================
- Hits 11038 11037 -1
Misses 790 790
🚀 New features to boost your workflow:
|
ilan-gold
approved these changes
May 16, 2026
d-v-b
added a commit
to d-v-b/zarr-python
that referenced
this pull request
May 18, 2026
Pulls in the upstream-main work that landed on the remote branch after the previous local merge: PR zarr-developers#3975 (refactor _ShardIndex to store chunks_per_shard explicitly), PR zarr-developers#3908 (cache default ArraySpec), zarr-developers#3935 (cd workflow), zarr-developers#3978 (zarr-metadata constants), zarr-developers#3979 (drop fixed-length utf32 warning). Conflicts resolved: - src/zarr/codecs/sharding.py imports: drop the now-unused `from operator import itemgetter` per zarr-developers#3975, keep our `ClassVar, Final, Literal` additions for the enum-deprecation types. - tests/test_codecs/test_sharding.py imports: combine `from zarr.core.metadata.v3 import ArrayV3Metadata` (ours, for the dict-shards coverage test) with `from zarr.core.indexing import c_order_iter` (theirs, for the new vectorized-slice tests). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have a spec at https://github.com/zarr-developers/zarr-extensions/tree/main/data-types/fixed_length_utf32, so we can remove the warning.