Relax validation for copilot_node_command#527
Merged
AntoineGS merged 7 commits intozbirenbaum:masterfrom Aug 15, 2025
Merged
Conversation
* use vim.system for version check in place of vim.fn.systemlist * disable executable check
it looks like these got commented out for use with the github workflow
Contributor
Author
|
NB: I initially made some changes to the makefile to run tests locally, but it looks like those changes were intentional to support github CI workflow, so I just restored it back to where it was when I found it |
Collaborator
|
Thank you! |
Contributor
Author
|
No problem, it took me over a week to get the PR together 😂 Let me know if/when you have any questions or feedback, happy to keep driving this |
AntoineGS
force-pushed
the
relax-node-cmd-validation
branch
from
4d5242c to
80540d8
Compare
Collaborator
|
I made a small improvement to the way it behave when nodejs is not found as it would nag constantly. |
Contributor
Author
|
Good catch. Thanks for merging that up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #498, where we found that
copilot_node_commandwould not allow commands that alias through version managers likemise x node@24 --node, which is a problem when working on a project that uses a node version older than 20.x.This removes the
vim.fn.executablechecks and just relies on thenode --versionoutput to determine if the configured command is usable or not, and slightly tweaks the way the command table is handled.