feat: Add cross-platform support for Windows and macOS #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BindingOx
commented
Feb 8, 2025
BindingOx
commented
- Add setup.bat for Windows installation
- Update package.json with cross-platform preinstall script
- Implement smart path resolution for markitdown executable
- Fix virtual environment path handling
- Add comprehensive test suite
- Update documentation with platform-specific instructions
- Add setup.bat for Windows installation - Update package.json with cross-platform preinstall script - Implement smart path resolution for markitdown executable - Fix virtual environment path handling - Add comprehensive test suite - Update documentation with platform-specific instructions
Author
|
tried my best with Claude help. unsure about any of this lol |
Owner
Thank you! I will review. |
|
When will this PR go live? really need it! |
Author
Can share some files of you can't wait. Oh actually I once pulled a fix from a PR. Look that up. Just backup your original files first |
Owner
|
Sorry I can't merge this code for two reasons:
|
Owner
|
Closed due to windows support added in #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.