Skip to content

Add a Zashi pipeline renderer#67

Merged
nuttycom merged 6 commits intozenhub-graphqlfrom
change-deployment-pipeline
Nov 1, 2024
Merged

Add a Zashi pipeline renderer#67
nuttycom merged 6 commits intozenhub-graphqlfrom
change-deployment-pipeline

Conversation

@str4d
Copy link
Collaborator

@str4d str4d commented Oct 31, 2024

Closes #64.

with open('public/zcash-change-deployment-pipeline.html', 'w') as f:
f.write(html_header)

for issue in tracked_issues.values():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current limitation: we don't filter out rows where everything is complete. That is intentional for now while we start filling out the DAG with the necessary data, but eventually we'll want to hide rows that are no longer relevant.

Copy link
Contributor

@daira daira Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to sort completed rows by their recency of completion, and then keep a minimum number for each platform and/or all the ones that were completed up to a given time ago.

For example: at least two completed rows for iOS, at least two completed rows for Android, and everything completed in the last 8 days. That would fit well with weekly meetings (8 days so that we don't miss anything that gets completed around the same time as a meeting).

In GitHub's GraphQl API, when an issue was closed is available in its closedAt attribute, documented here: https://docs.github.com/en/graphql/reference/objects#issue

@str4d str4d force-pushed the change-deployment-pipeline branch from b78137f to 564764f Compare October 31, 2024 04:48
This shows the progress of implementing tracked bugs and features,
and deploying them to the mobile SDKs and Zashi apps.

Closes #64.
@str4d str4d force-pushed the change-deployment-pipeline branch from 564764f to a666c1a Compare October 31, 2024 06:00
return

# Release not found in this repo
f.write('<td>📥</td>')
Copy link
Contributor

@nuttycom nuttycom Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful for this to link to the list of C-release issues for the repository, so that if a blocking relationship is missing then the correct release issue can be readily found (or created) and the relationship updated.

Suggested change
f.write('<td>📥</td>')
f.write('<td><a href="https://github.com/{}/labels/C-release">📥</a></td>'.format(repo_id))

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK 29c7e5a, this will be a good starting point.l

@nuttycom nuttycom merged commit ec032ce into zenhub-graphql Nov 1, 2024
@nuttycom nuttycom deleted the change-deployment-pipeline branch November 1, 2024 14:00
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants