Skip to content

Set up pages deployment to use a deploy key instead of an individual access token.#82

Merged
nuttycom merged 1 commit intomainfrom
pages_deploy_tokens
Aug 7, 2025
Merged

Set up pages deployment to use a deploy key instead of an individual access token.#82
nuttycom merged 1 commit intomainfrom
pages_deploy_tokens

Conversation

@nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Aug 7, 2025

No description provided.

@nuttycom nuttycom changed the title Set up pages deployment to use a deploy key instead of an individual … Set up pages deployment to use a deploy key instead of an individual access token. Aug 7, 2025
Copy link
Contributor

@y4ssi y4ssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuttycom nuttycom merged commit acfb7ff into main Aug 7, 2025
@nuttycom nuttycom deleted the pages_deploy_tokens branch August 7, 2025 15:24
Copy link
Collaborator

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc review

- name: Checkout repository
uses: actions/checkout@v4.2.2
with:
ssh-key: ${{ secrets.DEPLOY_KEY }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is missing the necessary permissions. Place this block between on: and jobs:

# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
permissions:
  contents: read
  pages: write
  id-token: write

# Allow only one concurrent deployment, skipping runs queued between the run
# in-progress and latest queued. However, do NOT cancel in-progress runs as we
# want to allow these production deployments to complete.
concurrency:
  group: "pages"
  cancel-in-progress: false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants