Conversation
str4d
force-pushed
the
generalized-refactor
branch
from
a5c72c9 to
1b8745b
Compare
daira
approved these changes
Dec 5, 2023
Contributor
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
utACK. All comments are non-blocking.
| u128_bytes[0..11].copy_from_slice(&di.0[..]); | ||
| u128::from_le_bytes(u128_bytes).try_into() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Consider adding TryFrom<DiversifierIndex> for u64 and From<DiversifierIndex> for u128.
| 0xff, 0xff, 0xff, 0xff, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| ]); | ||
| assert_matches!(u32::try_from(too_big), Err(_)); | ||
| } |
Contributor
There was a problem hiding this comment.
Consider adding more tests, in particular for DiversifierIndex::increment.
str4d
force-pushed
the
generalized-refactor
branch
from
1b8745b to
94b2378
Compare
This refactor was performed over several years. The protocol-specific logic now lives in protocol-specific crates, and this crate provides the common shared types and functions. Source: https://github.com/zcash/librustzcash Rev: zcash/librustzcash@5aa0e6c
str4d
force-pushed
the
generalized-refactor
branch
from
94b2378 to
69adc6d
Compare
Collaborator
Author
|
Force-pushed to add a missing dev-dependency and fix the commit message. |
This was referenced Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor was performed over several years. The protocol-specific logic now lives in protocol-specific crates, and this crate provides the common shared types and functions.
Source: https://github.com/zcash/librustzcash
Rev: zcash/librustzcash@5aa0e6c