Fix UB shm allocation cleanup crashes#11
Merged
zchuango merged 1 commit intoMay 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
posix_fallocate()afterftruncate()on Linux and validate remote object size beforemmap().EMSGSIZEfor payloads that cannot fit in the ring and fix fd truncation in the handshake.Test Plan
git diff --checkcmake --build build --target brpc_ubshm_unittest -j 8./build/test/brpc_ubshm_unittestNote: local macOS sandbox skips POSIX shm tests because
shm_openreturnsEPERM; Linux should execute them.Related to apache#3290 reviewer crash reports.