fix: normalize path separators for cross-platform gitignore matching#163
Merged
pan93412 merged 2 commits intopan93412/zea-8670-add-zeaburignore-ignore-flag-to-deploy-commandfrom Jan 28, 2026
Conversation
Co-authored-by: pan93412 <28441561+pan93412@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add .zeaburignore support for deployment filtering
fix: normalize path separators for cross-platform gitignore matching
Jan 28, 2026
bf32eb5
into
pan93412/zea-8670-add-zeaburignore-ignore-flag-to-deploy-command
2 checks passed
There was a problem hiding this comment.
Pull request overview
This PR fixes a cross-platform compatibility issue where gitignore pattern matching failed on Windows due to path separator differences. The fix ensures that .zeaburignore and .gitignore patterns work correctly on Windows by normalizing backslashes to forward slashes before pattern matching.
Changes:
- Normalize path separators to forward slashes using
filepath.ToSlash()before gitignore pattern matching ininternal/util/pack.go
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
filepath.Walkreturns paths with backslashes (e.g.,.agent\skills\test.txt), but gitignore pattern matching expects forward slashes. This caused.zeaburignoreand.gitignorepatterns to fail on Windows.Changes:
filepath.ToSlash()before matching against gitignore patterns ininternal/util/pack.go✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.