This repository was archived by the owner on Feb 5, 2024. It is now read-only.
Adds User-Agent header to _fetch #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@gschorkopf Sorry for this super dilatory response - but would be happy to merge if you could rebase off of the latest master. |
gschorkopf
force-pushed
the
add-user-agent
branch
from
a5ae930 to
5bc2dba
Compare
Contributor
Author
|
Happy to! There you go. |
* Creates a new file for __version__
gschorkopf
force-pushed
the
add-user-agent
branch
from
5bc2dba to
6d8128a
Compare
Contributor
|
Thanks! Have merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure: I'm not great at Python! Be gentle 😄
We're trying to add a header for "User-Agent", with the egg name and version. I've moved version out into it's own file to be reused in multiple places.
Additionally, we want to add this to all requests to Fastly. I'm not sure if _fetch is the best place to put this, if there are additional methods that add headers. Any suggestions?