Update tree-sitter-haskell#19
Conversation
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Per CI there seems to be an error with a node in some query which you'd need to look into. Also, you'll have to merge main (you can ignore the incoming changes, as that was just a formatting, nothing of content changed).
brandonchinn178
force-pushed
the
tree-sitter-haskell-update
branch
7 times, most recently
from
57c0dcd to
6e21b2a
Compare
|
Looks good overall, thank you! Could you share a quick before/after for comparison so me (and others who stumble across this) can have a better grasp on what changed? |
brandonchinn178
force-pushed
the
tree-sitter-haskell-update
branch
from
35a9618 to
19ed3a6
Compare
brandonchinn178
force-pushed
the
tree-sitter-haskell-update
branch
from
19ed3a6 to
67dd621
Compare
|
@MrSubidubi It's a complete rewrite of the grammar, so it's hard to say exactly what did/did not change. For the most part, the syntax highlighting should be mostly the same as before. There are a few changes, such as proper highlighting of infix qualified functions and some additional highlighting of builtins: Before: After: |
brandonchinn178
force-pushed
the
tree-sitter-haskell-update
branch
4 times, most recently
from
4792542 to
8235399
Compare
brandonchinn178
force-pushed
the
tree-sitter-haskell-update
branch
from
8235399 to
d21b169
Compare
|
@MrSubidubi Any idea when you'll have a chance to take a look? |
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Overall looks good, thank you for this and sorry for the delay in review! Was pulled into another project I needed to focus on for a bit. One comment and then we should be good to go!
And this definitely looks way better, thank you!
|
@MrSubidubi Should be good to go! |
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Let's go for it. Sorry for the delay and thanks!
Se one note but thats not urgent
| left_operand: [ | ||
| (variable) @function.call | ||
| (qualified | ||
| ((module) @title |
There was a problem hiding this comment.
I think we have a few of the @title ones and I am not so sure how well supported that is across themes. Maybe good to improve as a follow-up
2 participants
Previous commit was from Feb 14 2024. Updating to 0.23.1 from Nov 10 2024. Still old, but a bit newer. Specifically, looks like they did a complete overhaul in May 2024: tree-sitter/tree-sitter-haskell@f8e8da7
Unable to test this; installing as a Zed extension is failing with "Error: Failed to install dev extension: failed to compile grammar 'haskell'", and the zed logs isn't showing anything...