Remove python launch script dependency #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playdohface
commented
Oct 12, 2025
playdohface
commented
Oct 13, 2025
Contributor
|
Sorry for the late reply, was basically OOO this week, aside from some minor style stuff, looks good, thanks for your efforts! I very much lack context on the semantic side of things, so trust you with that, Aside from that, if you want some other channel to reach out for questions (e.g. Discord), I'd be more than happy to be available for you there. |
MrSubidubi
reviewed
Oct 18, 2025
| let output = String::from_utf8(output_bytes).map_err(|e| e.to_string())?; | ||
|
|
||
| let major_version_regex = | ||
| Regex::new(r#"version\s"(?P<major>\d+)(\.\d+\.\d+(_\d+)?)?"#).map_err(|e| e.to_string())?; |
Contributor
There was a problem hiding this comment.
What we could do here is uplift this into a OnceLock that is static so we only initialize this once and reuse it after for all future invocations. We have some examples for this in Zed itself. This should be available in the WASM context, admittedly though, I have never checked that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jdtls(.bat)on their $PATH, it's still used as before.Apart from making it easy to use the extension for people who can't or don't want to have python, this also allows us to manage the cache in the future (clearing caches is sadly a common interaction with java language servers)