Replies: 1 comment
-
|
Opened a PR for this: #59425 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
gpui has
borderbut no CSS-styleoutline. I'd like to propose adding one — mainly for layout-free focus rings.A focus ring should appear on
:focus-visiblewithout shifting content.bordercan't do that: taffy reserves the border box, so toggling a focus border nudges the layout. There's no primitive that draws a ring outside the box without affecting layout.A native
outline— uniform width/color/offset/style, drawn outside the border box, no layout effect, and composable withhover/focus_visiblelikeborder— would fill that gap and map onto Tailwind'soutline-*:It looks cheap to add (reuses the existing rounded-rect border quad; no shader or taffy changes). Happy to open a PR if this sounds reasonable.
Beta Was this translation helpful? Give feedback.
All reactions