Extend "..." support to more settings
#64399
porada
started this conversation in
Feature Requests
Replies: 2 comments
|
Sure, why not? |
0 replies
|
Using this comment for progress tracking. Current status
Meta PRs |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What are you proposing?
Support
"..."in more list settings, letting users add their own entries without replacing the inherited ones.After my initial research,
file_scan_inclusionsandhidden_filesseem the best next candidates.Why does this matter?
Having used
"..."in language server settings, I was surprised thatfile_scan_exclusionsdidn’t support it, especially given its default value. Adding one pattern shouldn’t require copying the entire default list and maintaining that copy as Zed’s defaults evolve.Are there any examples or context?
That led to #62769 for
file_scan_exclusions, followed by #64222 forread_only_files. For these settings,["...", "my-pattern"]extends the inherited list, while omitting"..."still replaces it.Possible approach
I’d be happy to implement these follow-ups in separate PRs if this direction is welcome, starting with the straightforward cases rather than applying the convention to every list.
The file pattern settings can reuse the existing
SplicingVecimplementation. I’m also open to generalizing that shared implementation later if other settings demonstrate a need.@SomeoneToIgnore — since you reviewed both PRs, I’d appreciate your input on this.
Additional candidates worth considering later on:
edit_predictions.disabled_globsedit_predictions_disabled_interminal.path_hyperlink_regexesAll reactions