Skip to content

Zed X11 CSD behavior should follow of most other programs #17623

@FreeAoi

Description

@FreeAoi

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

With current Zed x11 CSD implementation it check 2 things in order to know if CSD can be used:

CSD can be divided in drawing the titlebar and drawing the shadows. For zed be avaliable to drawing the titlebar it should check for another property called _NET_FRAME_EXTENTS instead of _GTK_FRAME_EXTENDS since this should be only check when trying to set shadows, for example chromium only check for _GTK_FRAME_EXTENDS to set shadows ref ref2 also not only chromium follows this approach.

Check example above Chrome with custom title bar
image

I'm using openbox and _GTK_FRAME_EXTENTS is not supported but it should be avaliable to draw the custom titlebar check chrome with the custom titlebar, the actual behavior is zed using the server decoration
image

In summary Zed should disable just shadows when _GTK_FRAME_EXTENTS is not supported but still draw the titlebar

Environment

Zed: v0.152.1 (Zed Preview)
OS: Linux X11 archcraft unknown
Memory: 7.5 GiB
Architecture: x86_64
GPU: Intel(R) Xe Graphics (TGL GT2) || Intel open-source Mesa driver || Mesa 24.2.2-arch1.1

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:workspaceFeedback for workspace management, layout, interactions, etcbugDEPRECATED label: use issue type 'Bug' insteadplatform:linuxhappens only on linux, not other OSplatform:linux/x11Linux X11staleLabel used by `stale` action

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions