-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Closed as not planned
Closed as not planned
Copy link
Labels
area:integrations/terminalFeedback for terminal integration, shell commands, etcFeedback for terminal integration, shell commands, etcarea:languages/goGo programming language supportGo programming language supportarea:tasksFeedback for Zed tasksFeedback for Zed tasksbugDEPRECATED label: use issue type 'Bug' insteadDEPRECATED label: use issue type 'Bug' insteadstaleLabel used by `stale` actionLabel used by `stale` action
Description
Check for existing issues
- Completed
Describe the bug / provide steps to reproduce it
From what I can tell, the arguments passed to the tasks are not escaped - no single quotes and no escapes for inner single quotes:
zed/crates/languages/src/go.rs
Line 518 in ba69f48
| VariableName::Symbol.template_value(), |
This leads to problems when the system shell is zsh, such as:
zsh:1: no matches found: ^ CreateUser$/^$
It is interpretting the regexp symbols as it should, because the argument is not surrounded by single quotes.
This is likely not a problem with just zsh, and just these specific tasks.
Environment
$ zsh --version
zsh 5.9 (x86_64-pc-linux-gnu)
$ zeditor --version
Zed 0.156.2 – /usr/lib/zed/zed-editor
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your Zed.log file to this issue.
Zed.log
Metadata
Metadata
Assignees
Labels
area:integrations/terminalFeedback for terminal integration, shell commands, etcFeedback for terminal integration, shell commands, etcarea:languages/goGo programming language supportGo programming language supportarea:tasksFeedback for Zed tasksFeedback for Zed tasksbugDEPRECATED label: use issue type 'Bug' insteadDEPRECATED label: use issue type 'Bug' insteadstaleLabel used by `stale` actionLabel used by `stale` action