Skip to content

Display what the tool is doing #27120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtfeldman merged 27 commits into from
Mar 20, 2025
Merged

Display what the tool is doing #27120

rtfeldman merged 27 commits into from
Mar 20, 2025

Conversation

@rtfeldman
Copy link
Contributor

@rtfeldman rtfeldman commented Mar 19, 2025

Screenshot 2025-03-19 at 4 56 47 PM

Release Notes:

  • N/A

rtfeldman and others added 26 commits March 19, 2025 11:38
@rtfeldman
wip
24ee2d0
@rtfeldman
Show more descriptive tool use
ec08561
@rtfeldman
Update individual tools to have the descriptive messages
603d367
@rtfeldman
more wip
093c093
@rtfeldman @agu-z
wip 2
d63a691 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
Make the edit tool description more concise.
6b2f0c7 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
Fix rendering
2cdfc10 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
before Clauding
bf57907 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
wip
815f239 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
wip 2
69ec8e6 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
checkpoint
c2f63b8 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
checkpoint
347f66e 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
anohter checkpoint
09f81b1 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
Add Tool::ui_text()
8d164c9 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
It works!
d66b017 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
Fix history
ce3bc14 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman @agu-z
overflow to ellipsis
1ed70ac 
Co-authored-by: Agus Zubiaga <hi@aguz.me>
@rtfeldman
Try something else for truncating to ellipsis
73a6e3d
@rtfeldman
Fix truncation (doesn't truncate to ellipsis, but at least truncates)
e141679
@rtfeldman
Improve pagination rendering
bedc4f7
@rtfeldman
Remove some unnecessary notify()s
c1941b5
@rtfeldman
Tweak rendering of directory contents listing tool
b7ec9eb
@rtfeldman
Avoid unnecessary to_string
f07a745
@rtfeldman
Use quotes when describing deletions
6e71c37
@rtfeldman
Use quotes in diagnostic tool
68124a2
@rtfeldman
Fix edit tool prompting
1bdf6df
@rtfeldman rtfeldman requested a review from agu-z March 19, 2025 21:02
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 19, 2025
@rtfeldman rtfeldman merged commit e3578fc into main Mar 20, 2025
15 checks passed
@rtfeldman rtfeldman deleted the tool-display branch March 20, 2025 13:16
CharlesChen0823 pushed a commit to CharlesChen0823/zed that referenced this pull request Mar 21, 2025
@rtfeldman @agu-z @CharlesChen0823
Display what the tool is doing (zed-industries#27120)
62b481f 
<img width="639" alt="Screenshot 2025-03-19 at 4 56 47 PM"
src="https://github.com/user-attachments/assets/b997f04d-4aff-4070-87b1-ffdb61019bd1"
/>

Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <hi@aguz.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agu-z agu-z Awaiting requested review from agu-z

Assignees

No one assigned

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rtfeldman