Refactor TextLayout to use Rc<RefCell> instead of Arc<Mutex> for improved performance #27177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roved performance
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
Contributor
|
This is a benchmark I did of scrolling to line 1000 in editor.rs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
TextLayoutis not shared by multiple threads, changing it toRc<RefCell<T>>should improve performance.I also found several codes with the same problem. If you think this change is beneficial, I will continue to improve it in the subsequent PR. 🙂
Release Notes: