Skip to content

Conversation

@danilo-leal
Copy link
Member

Also took the opportunity to rename the action to something that would be clearer in the command palette, from DeployPromptLibrary to OpenPromptLibrary.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 24, 2025
@maxdeviant
Copy link
Member

Also took the opportunity to rename the action to something that would be clearer in the command palette, from DeployPromptLibrary to OpenPromptLibrary.

We use Deploy in a number of other places across the app. Not sure we should diverge here (especially since it's a breaking change to the action).

@danilo-leal
Copy link
Member Author

Uhm, "assistant: deploy prompt library" is a confusing action name, though. Is there a way to change the label we display in the command palette without actually doing the action rename?

@notpeter
Copy link
Contributor

All the other "deploy" are toggling panels within the current workspace.
Where as the Prompt Library is actually opening a new window.

Screenshot 2025-03-24 at 11 29 09

Separately, is there a reason this action is only available in the AssistantPanel context and not globally?

@maxdeviant
Copy link
Member

Is there a way to change the label we display in the command palette without actually doing the action rename?

There is action_with_deprecated_aliases! to allow changing the name of the action while keeping an alias for it.

@danilo-leal
Copy link
Member Author

Added the action with action_with_deprecated_aliases! but confused about thevalue it is adding—did I do it correctly? What should I expect to see via the Command Palette?

@maxdeviant
Copy link
Member

Added the action with action_with_deprecated_aliases! but confused about thevalue it is adding—did I do it correctly? What should I expect to see via the Command Palette?

This is just so that users' existing keybindings don't break.

It makes assistant::DeployPromptLibrary still work as an action name in the keybindings.

But the command palette will show the new name.

@danilo-leal danilo-leal merged commit 03102b4 into main Mar 25, 2025
15 checks passed
@danilo-leal danilo-leal deleted the open-prompt-library-via-cp branch March 25, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants