Skip to content

Conversation

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Mar 25, 2025

It doesn't make sense to have Pixels: Mul<Pixels, Output = Pixels> as the output should be Pixels^2 (area), so these impls are removed. All code where these impls were used are improved by instead multiplying by f32 or usize.

Also adds math op impls that are present for Pixels but absent for ScaledPixels. Adds missing Mul<Pixels> for usize to both.

Release Notes:

  • N/A

It doesn't make sense to have `Pixels: Mul<Pixels, Output = Pixels>` as the output should be `Pixels^2` (area), so these impls are removed. All code where these impls were used are improved by instead multiplying by `f32` or `usize`.

Also adds math op impls that are present for `Pixels` but absent for `ScaledPixels`. Adds missing `Mul<Pixels> for usize` to both.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 25, 2025
@mgsloan mgsloan enabled auto-merge (squash) March 25, 2025 19:21
@mgsloan mgsloan merged commit 9fc570c into main Mar 25, 2025
15 checks passed
@mgsloan mgsloan deleted the remove-wrong-pixel-mul-impls-add-scaledpixels-ops branch March 25, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants