Set up Rust debugger code runner tasks #27571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of this is still hardcoded so there's a big cleanup effort left to do
still have a massive code clean up to do but it works as a Proof of Concept
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts the process of adding debug task locators to Zed's debugger system. A task locator is a secondary resolution phase that allows a debug task to run a command before starting a debug session and then uses the output of the run command to configure itself.
Locators are most applicable when debugging a compiled language but will be helpful for any language as well.
Architecture
At a high level, this works by adding a debug task queue to
Workspace. Which add's a debug configuration associated with aTaskIdwhenever a resolved task with a debug config is added toTaskInventory's queue. Then, when theSpawnInTerminaltask finishes running, it emits its task_id and the result of the ran task.When a ran task exits successfully,
WorkspacetellsProjectto start a debug session using its stored debug config, thenDapStorequeries theLocatorStoreto configure the debug configuration if it has a valid locator argument.Release Notes: