Skip to content

Conversation

@rtfeldman
Copy link
Contributor

Minor refactor that I'm extracting from a branch because it can stand alone.

  • Now we no longer spawn an executor for report_anthropic_event if it's just going to immediately fail due to API key being missing
  • report_anthropic_event now takes a String API key instead of Option<String> and the error reporting if the key is missing has been moved to the caller.
  • report_anthropic_event is longer coupled to AnthropicError, because all it ever did was generate an AnthropicEvent::Other, which in turn was then only used for log_err - so, can just be an anyhow::Result.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 16, 2025
@rtfeldman rtfeldman merged commit cfbc2d0 into main Jun 16, 2025
24 of 25 checks passed
@rtfeldman rtfeldman deleted the improve-telemetry branch June 16, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants