copilot: Wire up reasoning tokens for GPT models#53313
Merged
bennetbo merged 6 commits intozed-industries:mainfrom Apr 20, 2026
Merged
copilot: Wire up reasoning tokens for GPT models#53313bennetbo merged 6 commits intozed-industries:mainfrom
bennetbo merged 6 commits intozed-industries:mainfrom
Conversation
Fix two issues with reasoning support in the Copilot provider: - Responses API path: use the user's thinking_effort setting instead of hardcoding Medium effort - Chat Completions path: compute and pass thinking_budget when thinking is enabled, instead of unconditionally setting it to None
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
guild
zed-codeowner-coordinator
bot
requested review from
danilo-leal and
maxbrunsfeld
and removed request for
a team
zed-community-bot
bot
added
the
first contribution
mikayla-maki
approved these changes
Apr 7, 2026
|
Any chance of this getting merged soon? Having to use VSCode for high thinking for GPT models is big sad. |
SomeoneToIgnore
added
the
area:ai
Member
|
Hey, this was not actually working for me. I pushed a commit matching VSCode's behaviour and it seems to work. Will test it a bit more and merge soon. |
bennetbo
reviewed
Apr 20, 2026
| && self | ||
| .supported_endpoints | ||
| .contains(&ModelSupportedEndpoint::Responses) | ||
| self.supported_endpoints |
Member
There was a problem hiding this comment.
Changed this so that we prefer the responses API when it's available, since the old API does not seem to support reasoning_effort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues with reasoning support in the Copilot provider:
Self-Review Checklist:
Closes #52140
Release Notes: