Skip to content

Fix a bug where Zed incorrectly keeps a removed pane as the active pane#56229

Merged
JosephTLyons merged 2 commits into
mainfrom
fix-active-pane-after-auto-close
May 9, 2026
Merged

Fix a bug where Zed incorrectly keeps a removed pane as the active pane#56229
JosephTLyons merged 2 commits into
mainfrom
fix-active-pane-after-auto-close

Conversation

@JosephTLyons
Copy link
Copy Markdown
Collaborator

@JosephTLyons JosephTLyons commented May 8, 2026

This PR should fix the issue Ben ran into with Auto Watch. It isn’t a bug in Auto Watch itself, but a bug in Zed’s active-pane bookkeeping when Zed auto-closes a pane. Ben had a screen share in its own split; when the share ended, the tab closed, and with it, the pane. In this case, Zed was holding onto the removed pane as the active pane, so Auto Watch was trying to open the next screen share in a pane that was no longer part of the workspace.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed a bug where Zed incorrectly kept a removed pane as the active pane.

…always set another pane as active in its place
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 8, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 8, 2026
@JosephTLyons JosephTLyons changed the title Fix active pane bug after pane is automatically closed Fix bug where Zed incorrectly holds onto a non-existent pane as the active one May 8, 2026
@JosephTLyons JosephTLyons changed the title Fix bug where Zed incorrectly holds onto a non-existent pane as the active one Fix a bug where Zed incorrectly holds onto a non-existent pane as the active one May 8, 2026
@JosephTLyons JosephTLyons changed the title Fix a bug where Zed incorrectly holds onto a non-existent pane as the active one Fix a bug where Zed incorrectly keeps a removed pane as the active pane May 8, 2026
@JosephTLyons JosephTLyons force-pushed the fix-active-pane-after-auto-close branch from 3bf7ff4 to 48f8ef0 Compare May 8, 2026 21:52
@JosephTLyons JosephTLyons added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit c8f09ca May 9, 2026
32 checks passed
@JosephTLyons JosephTLyons deleted the fix-active-pane-after-auto-close branch May 9, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants