Skip to content

Fix active pane border and pane opacity dimming showing simultaneously on editor panes and terminal panes#56595

Open
usizu wants to merge 1 commit into
zed-industries:mainfrom
usizu:fix/active-pane-border-duplicate
Open

Fix active pane border and pane opacity dimming showing simultaneously on editor panes and terminal panes#56595
usizu wants to merge 1 commit into
zed-industries:mainfrom
usizu:fix/active-pane-border-duplicate

Conversation

@usizu
Copy link
Copy Markdown

@usizu usizu commented May 13, 2026

When active_pane_modifiers.border_size is set in settings.json, both the active editor pane and the active terminal pane would display a border simultaneously, making it impossible to tell which pane actually has focus. The pane opacity dimming also renders simultaneously before this fix.

  1. Before fix: impossible to tell which pane has focus
image
  1. After fix: only one pane has focus
image

The root cause is that both the workspace center and the terminal panel pass their own active_pane to PaneRenderContext, so each pane group unconditionally marks its active pane for border rendering. The fix adds a focus check so active_pane_ix is only set when the pane actually has keyboard focus, ensuring only the truly focused pane gets the border (and the inactive_opacity dimming applies correctly to unfocused groups).

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed active pane border being drawn on both the editor pane and terminal pane simultaneously

When `active_pane_modifiers.border_size` is set, both the active center
pane and the active terminal pane would display a border simultaneously,
making it impossible to tell which pane actually has focus.

The root cause is that both the workspace center and the terminal panel
pass their own `active_pane` to `PaneRenderContext`, so each pane group
unconditionally marks its active pane for border rendering. The fix adds
a focus check so `active_pane_ix` is only set when the pane actually has
keyboard focus, ensuring only the truly focused pane gets the border
(and the inactive_opacity dimming applies correctly to unfocused groups).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 13, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label May 13, 2026
@ChristopherBiscardi ChristopherBiscardi added the area:editor Feedback for code editing, formatting, editor iterations, etc label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:editor Feedback for code editing, formatting, editor iterations, etc cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants