Fix Linux compatibility: sarray qsort_r signature, uname detection, CRLF#40
Open
LilySu wants to merge 1 commit intozedshaw:masterfrom
Open
Fix Linux compatibility: sarray qsort_r signature, uname detection, CRLF#40LilySu wants to merge 1 commit intozedshaw:masterfrom
LilySu wants to merge 1 commit intozedshaw:masterfrom
Conversation
…ings - Makefile: replace lsb_release -si/Ubuntu with uname -s/Linux for cross-distro compatibility (complements PR zedshaw#24) - sarray.c: add _GNU_SOURCE to expose qsort_r on glibc, fix argument order (comparator before thunk), fix parameter name thunk -> data - tests/runtests.sh: strip CRLF line endings that broke bash on WSL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Linux compatibility: sarray.c qsort_r signature and Makefile OS detection
cross-distro compatibility (complements PR Makefile now works on multiple linux distributions #24)
order and fix parameter name thunk -> data