Skip to content

name change for set_onboarding_message_click_time#603

Merged
mircealungu merged 4 commits into
masterfrom
API-onboarding-nameChanging
May 14, 2026
Merged

name change for set_onboarding_message_click_time#603
mircealungu merged 4 commits into
masterfrom
API-onboarding-nameChanging

Conversation

@AnnieeBennie
Copy link
Copy Markdown
Collaborator

changed the name for set_onboarding_message_click_time to mark_onboarding_message_dismissed

@AnnieeBennie AnnieeBennie requested a review from mircealungu May 12, 2026 13:31
@github-actions
Copy link
Copy Markdown

ArchLens - No architecturally relevant changes to the existing views

The 26-05-03 migration is already on master and has run on production,
so editing it in place doesn't rename the column on existing databases.
This forward migration ALTERs the column so all environments converge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mircealungu
Copy link
Copy Markdown
Member

mircealungu commented May 14, 2026

@AnnieeBennie heads up — I just pushed a small commit (c4a91be3) to this branch to add a forward migration.

Background: the existing 26-05-03--add_user_onboarding_message_table.sql is already on master and has run on production. When a migration has already executed, editing the file in place (which is what this PR does) doesn't re-apply on databases that already ran it — the migration runner sees it as "done" and skips.

So we need an additional migration, that will ALTER the table to do the rename.

The new file tools/migrations/26-05-14--rename_message_click_time_to_dismissed.sql does an ALTER TABLE … CHANGE COLUMN so existing environments converge. Fresh environments still get the renamed column directly from the edited 26-05-03 file, so both paths arrive at the same end state.

General rule of thumb: once a migration is on master (and likely deployed), treat it as immutable history. Any subsequent schema change needs a new dated migration.

Also worth doing in this PR (optional, small):

  • Rename the helper update_user_onboarding_message_timeset_message_dismissed_time to mirror set_message_shown_time.

Keeping the rename only in the new forward migration. Editing an
already-deployed migration creates a fresh-vs-existing divergence
and would also conflict with the 26-05-14 ALTER TABLE on fresh DBs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mircealungu
Copy link
Copy Markdown
Member

Actually, please @AnnieeBennie do this:

  • Rename the helper update_user_onboarding_message_time → set_message_dismissed_time to mirror set_message_shown_time.

update_user_onboarding_message_time is now set_message_dismissed_time
@AnnieeBennie
Copy link
Copy Markdown
Collaborator Author

@mircealungu I updated the name

@mircealungu mircealungu merged commit 1281e86 into master May 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants