Add ia32/x64 architectures support #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo
approved these changes
Oct 13, 2017
Contributor
leo
left a comment
leo
left a comment
There was a problem hiding this comment.
Looks very good! Now that it's reviewed, can you add the documentation to readme.md as well?
Contributor
|
@chabou ping |
chabou
commented
Oct 31, 2017
| Accepts a platform (like "darwin" or "win32") and an architecture (like "ia32", or "x64") to download the appropriate copy your app for. I generally suggest using either `process.platform()` ([more](https://nodejs.org/api/process.html#process_process_platform)) and `process.arch()` ([more](https://nodejs.org/api/process.html#process_process_arch)) to retrieve these strings. | ||
|
|
||
| If the cache isn't filled yet or doesn't contain a download link for the specified platform, it will respond like `/`. | ||
| If :arch parameter is missing, `x64` is used by default. |
Author
There was a problem hiding this comment.
I think that a 404 is returned if cache isn't filled for this platform. See https://github.com/zeit/hazel/blob/2d54cb913cfd6ceb9ef491285f33ed74a2cd1847/lib/routes.js#L79-L81
Author
|
I rebased this PR against master and add documentation for this feature. |
2 tasks
|
Hey! I'd like to help with 32bit support. @chabou made some commits, but I don't know what this means: How can I help to resolve these conflicts? |
Author
Member
|
Going to close this since it's stale, I think we might still want to support this though 🤔 cc @leo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16
This feature is not yet documented in
README.mdbut I'll do that after reviewThis PR adds 2 new routes
/download/:platform/:archand/update/:platform/:arch/:version.archparameter could beia32orx64(same values thanelectron-builder).If
archis omitted,x64is used by default.When fetching/caching packages from Github release, it supposes that package is
x64except if its name, without extension, ends withi386,i686oria32.