Prevent loosing focus after a char composition ended by Tab key. Fix #1341 #1349

Merged
merged 1 commit into from Jan 7, 2017

Projects

None yet

2 participants

@chabou
Contributor
chabou commented Jan 6, 2017

When a char composition ends with a Tab key, after a first onKeyDown_(e) call, another one occurs with a different keycode (192) but the same timestamp and same key (Tab).
This second onKeyDown_ event cause a blur and Term loose its focus.

Notice: A breakpoint in onTextInput_ prevent this second event. Race condition ?

@chabou chabou Prevent loosing focus after a char composition ended by Tab key. Fix #…
cb13fdd
@rauchg rauchg merged commit 1b6d925 into zeit:master Jan 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rauchg
Contributor
rauchg commented Jan 7, 2017

Really appreciate your time debugging this @chabou

@chabou chabou deleted the chabou:prevent_double_onkeydown branch Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment