Skip to content

Proof of concept to support deep parsing of query string params#2605

Closed
chrismatheson wants to merge 1 commit intovercel:masterfrom
chrismatheson:deeper-parsing-of-querystring
Closed

Proof of concept to support deep parsing of query string params#2605
chrismatheson wants to merge 1 commit intovercel:masterfrom
chrismatheson:deeper-parsing-of-querystring

Conversation

@chrismatheson
Copy link

Need to add tests but this is a basic proof of concept for a fix for #2530

Before i finish this off completely, is this an acceptable solution? i wasn't sure about bringing in a new dependency?

@chrismatheson chrismatheson changed the title POC for using qs Proof of concept to support deep parsing of query string params Jul 20, 2017
@timneutkens
Copy link
Member

I'm not sure if we want to do this inside of next, since qs is a pretty big library

@timneutkens
Copy link
Member

Lets close this. qs is too big to pull in for this feature. Users can parse deep-nested queries themselves using the full url. Which we do provide.

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants