Allow app component to be wrapped with custom enhancer when rendering #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinekb
force-pushed
the
render-page-enhancer
branch
from
270987d to
c76875a
Compare
timneutkens
reviewed
Jul 11, 2018
| if (ctx.query.withEnhancer) { | ||
| options = enhanceComponent | ||
| } else if (ctx.query.withEnhanceComponent) { | ||
| options = { enhanceComponent } |
Member
There was a problem hiding this comment.
This should also test enhanceApp
timneutkens
reviewed
Jul 11, 2018
| const renderPage = (options = Page => Page) => { | ||
| let EnhancedApp = App | ||
| let EnhancedComponent = Component | ||
| if (typeof options === 'function') { |
Member
There was a problem hiding this comment.
Lets add a comment here that this is for backwards compatibility
albinekb
force-pushed
the
render-page-enhancer
branch
from
0906b3d to
c6513ba
Compare
1 task
timneutkens
approved these changes
Jul 13, 2018
Member
|
Thanks! |
|
Thanks so much for picking up the slack while I'm on holiday, this looks great 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #4288
Fixes #4269